Skip to content

Remove deprecated three workspace - #809

Open
charlieforward9 wants to merge 1 commit into
codex/citrus-tree-labfrom
codex/remove-three-module
Open

charlieforward9 wants to merge 1 commit into
codex/citrus-tree-labfrom
codex/remove-three-module

Conversation

@charlieforward9

@charlieforward9 charlieforward9 commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

Moves Seasonal Farm to the native TreeLayer package, removes the deprecated three workspace, and updates migration docs. The compact garden lands first in #808.

Package removal requires a major release after compatible native packages are published.

Stack: #808 → #809 → #814 → #815 → #806 last.

Validation: root/website Yarn installs and builds, strict API types, lint, 2,015 Node tests, 38 example tests, and Seasonal Farm on WebGL2 and WebGPU.


Note

Medium Risk
Breaking removal of a published npm package and broad doc/site redirect changes; runtime impact is limited to consumers still importing @deck.gl-community/three.

Overview
Removes the deprecated @deck.gl-community/three compatibility workspace and finishes the Seasonal Farm migration to native TreeLayer from @deck.gl-community/layers.

Seasonal Farm lives under examples/layers/seasonal-farm with updated deps, Vite alias, website gallery/sidebar, and live doc example imports. The playground registry and root tsconfig/vitest aliases no longer reference the three package. Docs state the workspace is removed (not temporarily re-exported), with upgrade-guide notes that npm removal is a major-version breaking change.

Website: adds @docusaurus/plugin-client-redirects from old /docs/modules/three/* and /examples/three/seasonal-farm to the layers TreeLayer docs and new example path; drops the three module from sidebars and WebGPU matrix.

Dev planning: new dev/tree-splat-stack.md and revisions to dev/splat-layer-spark-design.md document landing order #808 → #809 → #814 → #815 → #806.

Tests: Seasonal Farm browser spec calls getCrop with deck accessor context, drains WebGL work before remount, and extends remount readiness timeouts for CI.

Reviewed by Cursor Bugbot for commit a1cb3dd. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Coverage

Stmts: 49.06% | Branch: 42.77% | Funcs: 43.84% | Lines: 48.68%

Test Files 209 passed (209)

@greptile-apps

greptile-apps Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[Medium impact] The PR appears safe to merge, with package removal reserved for the documented major release.

Summary

Moves Seasonal Farm to @deck.gl-community/layers and removes the deprecated three workspace.

  • The deprecated three workspace is removed.
  • Seasonal Farm now uses the native layers package and route.
  • Project notes now place inventory streaming after scene and Coit work.

Reviews (42) · Last reviewed commit: "Remove deprecated three workspace after ..." · Reviewed by Greptile

@charlieforward9
charlieforward9 force-pushed the codex/remove-three-module branch 2 times, most recently from c20e672 to 5538fa4 Compare October 7, 2026 01:46
@charlieforward9
charlieforward9 force-pushed the codex/citrus-tree-lab branch 2 times, most recently from 09a35e1 to a322080 Compare October 7, 2026 02:31
@charlieforward9
charlieforward9 force-pushed the codex/remove-three-module branch 2 times, most recently from 825ed4e to 800c220 Compare October 7, 2026 18:27
@charlieforward9
charlieforward9 force-pushed the codex/remove-three-module branch from 800c220 to 046810c Compare October 7, 2026 20:06
@charlieforward9
charlieforward9 changed the base branch from codex/citrus-tree-lab to codex/coit-community October 7, 2026 20:06
@greptile-apps

greptile-apps Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Comments Outside Diff

These findings could not be posted inline.

  • P1 Playground rejects streamed trees modules/playground/src/schemas/community-geo-layers.ts:229 ▶

    TreeLayerPropsSchema still accepts only row inputs. A valid document using getTileData: '@@#inventory', getDistantCanopyColor or cache controls fails strict parsing before the playground creates the layer.

    The existing schema-coverage test also fails: TreeLayer.defaultProps now includes inventory defaults that this schema lacks. Add the public streaming fields and explicitly exclude internal defaults from that test.

  • P1 Coit disables website scrolling examples/layers/coit/styles.css:19 ▶

    Opening Coit on the website imports this stylesheet into the whole page. These rules set html and body to overflow: hidden, so readers cannot scroll long docs pages after opening the example and navigating elsewhere. The global button and h1 rules also change website controls and headings.

    Keep standalone page rules in the standalone entry point, and scope shared styles to the Coit container.

    Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Comment thread docs/upgrade-guide.md Outdated
@charlieforward9
charlieforward9 force-pushed the codex/remove-three-module branch from f469bc9 to be63857 Compare October 7, 2026 21:04
@charlieforward9
charlieforward9 force-pushed the codex/coit-community branch 2 times, most recently from 5d464be to a282a7e Compare October 7, 2026 21:55
@charlieforward9
charlieforward9 force-pushed the codex/remove-three-module branch from be63857 to 3740f4d Compare October 7, 2026 21:55
@charlieforward9
charlieforward9 force-pushed the codex/remove-three-module branch 2 times, most recently from 6b6cc81 to 4cfd86c Compare October 8, 2026 06:53

@ibgreen ibgreen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed Seasonal Farm's migration to the public native TreeLayer, legacy three workspace removal, aliases/registry changes, lockfile and migration/navigation updates.

Fit: consolidate the canonical renderer in layers and eliminate the redundant compatibility workspace after the migration. Removing a published package/import path is a release-level breaking change; preserve clear replacement imports and deliberate major-release sequencing.

Current merge gate: test-headless fails at this head. The inspected run shows Seasonal Farm's expected 80 versus actual 75 assertion and a 90-second reduced-motion forest timeout. Diagnose the failures and obtain green checks on the final revision. Keep the cleanup above #808 and validate after upstream stack changes are incorporated.

Approval submitted as requested by the maintainer; the failing CI and breaking-release gate remain. Review used source/diffs and hosted logs, with no local suites rerun.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit b559184. Configure here.

Comment thread website/docusaurus.config.js
@charlieforward9
charlieforward9 force-pushed the codex/remove-three-module branch 2 times, most recently from 2651d10 to f1e6745 Compare October 11, 2026 21:27
@charlieforward9
charlieforward9 force-pushed the codex/citrus-tree-lab branch 2 times, most recently from 7c93e6a to 602cc2e Compare October 12, 2026 07:06
@charlieforward9
charlieforward9 force-pushed the codex/remove-three-module branch from f1e6745 to 8072e02 Compare October 12, 2026 07:22
@charlieforward9
charlieforward9 force-pushed the codex/remove-three-module branch 3 times, most recently from ec82cd2 to 8e71f65 Compare October 12, 2026 09:04
@charlieforward9
charlieforward9 force-pushed the codex/remove-three-module branch from ef880ac to 544e022 Compare October 13, 2026 01:48
@charlieforward9 charlieforward9 changed the title refactor: migrate Seasonal Farm and remove legacy three workspace Remove deprecated three workspace and migrate Seasonal Farm Oct 13, 2026
@charlieforward9
charlieforward9 force-pushed the codex/remove-three-module branch from 544e022 to 1ff0232 Compare October 13, 2026 03:05
@charlieforward9 charlieforward9 changed the title Remove deprecated three workspace and migrate Seasonal Farm Remove deprecated three workspace after regular TreeLayer examples Oct 13, 2026
@charlieforward9
charlieforward9 force-pushed the codex/remove-three-module branch 2 times, most recently from e1410cc to 97358d4 Compare October 13, 2026 04:01
@charlieforward9
charlieforward9 force-pushed the codex/remove-three-module branch from 97358d4 to c0e17fb Compare October 13, 2026 04:51

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants