Repository navigation
Remove deprecated three workspace - #809
charlieforward9 wants to merge 1 commit into
Conversation
CoverageStmts: 49.06% | Branch: 42.77% | Funcs: 43.84% | Lines: 48.68%
|
|
c20e672 to
5538fa4
Compare
09a35e1 to
a322080
Compare
825ed4e to
800c220
Compare
a322080 to
0f467f6
Compare
0f467f6 to
7baaff7
Compare
800c220 to
046810c
Compare
Comments Outside DiffThese findings could not be posted inline.
|
fc278f9 to
149439b
Compare
046810c to
013432a
Compare
149439b to
e38b062
Compare
013432a to
f469bc9
Compare
f469bc9 to
be63857
Compare
5d464be to
a282a7e
Compare
be63857 to
3740f4d
Compare
6b6cc81 to
4cfd86c
Compare
ibgreen
left a comment
There was a problem hiding this comment.
Reviewed Seasonal Farm's migration to the public native TreeLayer, legacy three workspace removal, aliases/registry changes, lockfile and migration/navigation updates.
Fit: consolidate the canonical renderer in layers and eliminate the redundant compatibility workspace after the migration. Removing a published package/import path is a release-level breaking change; preserve clear replacement imports and deliberate major-release sequencing.
Current merge gate: test-headless fails at this head. The inspected run shows Seasonal Farm's expected 80 versus actual 75 assertion and a 90-second reduced-motion forest timeout. Diagnose the failures and obtain green checks on the final revision. Keep the cleanup above #808 and validate after upstream stack changes are incorporated.
Approval submitted as requested by the maintainer; the failing CI and breaking-release gate remain. Review used source/diffs and hosted logs, with no local suites rerun.
b8873d5 to
4d91315
Compare
4cfd86c to
387a865
Compare
4d91315 to
83a59b4
Compare
387a865 to
b559184
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b559184. Configure here.
83a59b4 to
270e984
Compare
2651d10 to
f1e6745
Compare
7c93e6a to
602cc2e
Compare
f1e6745 to
8072e02
Compare
602cc2e to
0791382
Compare
ec82cd2 to
8e71f65
Compare
2896cb6 to
fdfa988
Compare
ef880ac to
544e022
Compare
fdfa988 to
dfb8971
Compare
544e022 to
1ff0232
Compare
e1410cc to
97358d4
Compare
4212c0d to
85487e2
Compare
97358d4 to
c0e17fb
Compare

Moves Seasonal Farm to the native TreeLayer package, removes the deprecated three workspace, and updates migration docs. The compact garden lands first in #808.
Package removal requires a major release after compatible native packages are published.
Stack: #808 → #809 → #814 → #815 → #806 last.
Validation: root/website Yarn installs and builds, strict API types, lint, 2,015 Node tests, 38 example tests, and Seasonal Farm on WebGL2 and WebGPU.
Note
Medium Risk
Breaking removal of a published npm package and broad doc/site redirect changes; runtime impact is limited to consumers still importing
@deck.gl-community/three.Overview
Removes the deprecated
@deck.gl-community/threecompatibility workspace and finishes the Seasonal Farm migration to nativeTreeLayerfrom@deck.gl-community/layers.Seasonal Farm lives under
examples/layers/seasonal-farmwith updated deps, Vite alias, website gallery/sidebar, and live doc example imports. The playground registry and roottsconfig/vitestaliases no longer reference the three package. Docs state the workspace is removed (not temporarily re-exported), with upgrade-guide notes that npm removal is a major-version breaking change.Website: adds
@docusaurus/plugin-client-redirectsfrom old/docs/modules/three/*and/examples/three/seasonal-farmto the layers TreeLayer docs and new example path; drops the three module from sidebars and WebGPU matrix.Dev planning: new
dev/tree-splat-stack.mdand revisions todev/splat-layer-spark-design.mddocument landing order #808 → #809 → #814 → #815 → #806.Tests: Seasonal Farm browser spec calls
getCropwith deck accessor context, drains WebGL work before remount, and extends remount readiness timeouts for CI.Reviewed by Cursor Bugbot for commit a1cb3dd. Bugbot is set up for automated code reviews on this repo. Configure here.